[PATCH] pager: honour aliases (issue3532)

Matt Mackall mpm at selenic.com
Sun Oct 20 17:27:08 CDT 2013


On Sat, 2013-10-12 at 19:01 -0700, David Soria Parra wrote:
> # HG changeset patch
> # User David Soria Parra <dsp at experimentalworks.net>
> # Date 1381629094 25200
> #      Sat Oct 12 18:51:34 2013 -0700
> # Node ID 39084a836b0525cbcabc60b5200e83a5cd91577d
> # Parent  1b2f9d36953e6ed384a044c1e73cb3a1aa072004
> pager: honour aliases (issue3532)
> 
> If paging is configured for a command all it's aliases will be paged as
> well. This will make attend=log cause 'hg history' to run the pager as
> well as custom aliases defined with [alias].

I think I have to say no to this one. People might be using aliases to
avoid/get paging today so this is a clear BC breakage... and offers
nothing users can't do for themselves in their config file (which
they're already editing), possibly by adding --pager. 

It's also possible with aliases to create things (for instance with
revsets and templates) that are radically different in usage than the
commands they alias, so that they will be thought of as new commands
rather than simply tweaked commands.

To Durham's complaint that there's no easy way to append to global
attend settings, I think the right fix is to add a new more granular
setting, perhaps:

[pager]
attend-fancylog = True
attend-export = False

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list