[PATCH 1 of 4 stable] shelve: remove unused variable assignment

[Mads Kiilerich]

On 10/31/2013 04:22 PM, FUJIWARA Katsunori wrote:
> At Thu, 31 Oct 2013 08:42:01 -0400,
> Augie Fackler wrote:
>> On Mon, Oct 28, 2013 at 11:00:52PM +0100, Mads Kiilerich wrote:
>>> # HG changeset patch
>>> # User Mads Kiilerich <madski at unity3d.com>
>>> # Date 1382995940 -3600
>>> #      Mon Oct 28 22:32:20 2013 +0100
>>> # Branch stable
>>> # Node ID a45cf16389bcf2fb64dd95047bf0357e8313c83c
>>> # Parent  1d7a36ff2615e6e12ce65681db4e07622e7b60d1
>>> shelve: remove unused variable assignment
>> Dropping this one, it breaks shelve, at least with foozy's patches
>> applied.
> This patch breaks shelve, even if my patches are not applied.
>
> "readshelvedfiles()" invocation here is requierd to ensure that
> shelved changes named as specified exist after that line.

So you say that this pretty pure function with a return value that is 
assigned to an unused variable is necessary for the not-so-pure side 
effect that the function can raise exceptions. Ok.

Your patch seems good - it fixes both the need for a comment and the 
pyflakes failure.

/Mads