[PATCH 6 of 6] parsers: use a lookup table to convert hex to binary

Benoit Boissinot bboissin at gmail.com
Tue Sep 10 14:42:52 CDT 2013


On Mon, Sep 9, 2013 at 5:15 AM, Augie Fackler <raf at durin42.com> wrote:

> On Sat, Sep 07, 2013 at 01:40:40PM -0700, Siddharth Agarwal wrote:
> > # HG changeset patch
> > # User Siddharth Agarwal <sid0 at fb.com>
> > # Date 1378540764 25200
> > #      Sat Sep 07 00:59:24 2013 -0700
> > # Node ID 6638dd23999d66a95ce28816f035a1d051963290
> > # Parent  8c45bfd4369fc7075fb2a2aca7cea6f492bd7782
> > parsers: use a lookup table to convert hex to binary
>
> Series looks reasonable, but it's important enough I want someone else
> to glance at it.
>

Serie looks good to me.
Though I'm not a huge fan of the temporary assumption on cache preloading
in #3.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20130910/a09d8584/attachment.html>


More information about the Mercurial-devel mailing list