[PATCH 6 of 6] parsers: use a lookup table to convert hex to binary

Benoit Boissinot bboissin at gmail.com
Tue Sep 10 14:53:45 CDT 2013


On Tue, Sep 10, 2013 at 9:51 PM, Siddharth Agarwal <sid0 at fb.com> wrote:

> On 09/10/2013 12:42 PM, Benoit Boissinot wrote:
>
>> Serie looks good to me.
>> Though I'm not a huge fan of the temporary assumption on cache preloading
>> in #3.
>>
>
> I tried combining patches 3 and 4 into one, but I found that there was
> just too much going on. As it is, patch 4 is confusing enough.
>

That was my conclusion as well, couldn't see how to improve it.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20130910/3ef7e792/attachment.html>


More information about the Mercurial-devel mailing list