[PATCH] parse_manifest: rewrite to use memchr

Benoit Boissinot bboissin at gmail.com
Tue Sep 10 16:03:28 CDT 2013


On Tue, Sep 10, 2013 at 10:54 PM, Siddharth Agarwal <sid0 at fb.com> wrote:

> On 09/10/2013 12:52 PM, Benoit Boissinot wrote:
>
>> you can now move the declaration of zero and newline here (and
>> initialize).
>>
>
> What do you mean by "and initialize"?
>

= NULL (agreed, it's not required, I just find it more future proof)
(I don't think that's very important, moving the declaration inside the
loop is the most useful part, since it makes it clearer that no state is
used across iteration and the variable isn't used past the loop)

Benoit
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20130910/7290805f/attachment.html>


More information about the Mercurial-devel mailing list