[PATCH 1 of 1 V2] histedit: abort if there are multiple roots in "--outgoing" revisions

Kevin Bullock kbullock+mercurial at ringworld.org
Tue Sep 17 09:31:01 CDT 2013


On 14 Sep 2013, at 3:12 PM, Matt Mackall wrote:

> On Thu, 2013-09-12 at 22:33 -0500, Kevin Bullock wrote:
>> On 9 Sep 2013, at 8:51 AM, FUJIWARA Katsunori wrote:
>> 
>>> # HG changeset patch
>>> # User FUJIWARA Katsunori <foozy at lares.dti.ne.jp>
>>> # Date 1378733863 -32400
>>> #      Mon Sep 09 22:37:43 2013 +0900
>>> # Node ID f0edc4e70f976b20d0c886a287b472a629789329
>>> # Parent  1d07bf106c2ad1c7ef5e257e754ca8d858bd04b0
>>> histedit: abort if there are multiple roots in "--outgoing" revisions
>> 
>> LGTM except that I think we need to bikeshed the messages we give the
>> user here. Telling them the outgoing changesets have "multiple roots"
>> will be terrifying. I don't have any better suggestions, though (yet).
> 
> Can we bikeshed by follow-up patch then?

I'm fine with that.

> This appears to be a bugfix that belongs on stable, yes?

Yeah, probably.

pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
Kevin R. Bullock



More information about the Mercurial-devel mailing list