[PATCH 5 of 5 RFC py3 support] run-tests: minimum changes required to make run-tests work in python3

Matt Mackall mpm at selenic.com
Thu Sep 19 15:53:39 CDT 2013


On Thu, 2013-09-19 at 16:37 -0400, Augie Fackler wrote:
> 
> On Thu, Sep 19, 2013 at 4:36 PM, Matt Mackall <mpm at selenic.com> wrote:
>         > This is just doing the dumbest thing possible and assumes
>         test
>         > input/output is all utf-8. This works for now, at least for
>         the simple
>         > tests I'm interested in trying to run, so I'm calling it
>         progress
>         > until I have to come back and figure out something smarter.
>         
>         
>         Please tell me this doesn't mean subprocess can't return byte
>         streams in
>         3.x.
> 
> 
> 
> I haven't looked at all. I'm literally doing the dumbest thing
> possible to try and get to 'hg version' with a working testsuite.

Ok. Let's learn a bit more before proceeding. A quick test here with
Py3.2 shows that subprocess pipe fds are in fact in byte mode.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list