[PATCH 13 of 13 V2 py3 support] run-tests: minimum changes required to make run-tests work in python3

Kevin Bullock kbullock+mercurial at ringworld.org
Sat Sep 21 22:55:06 CDT 2013


On 20 Sep 2013, at 9:23 AM, Augie Fackler wrote:

> # HG changeset patch
> # User Augie Fackler <raf at durin42.com>
> # Date 1379621130 14400
> #      Thu Sep 19 16:05:30 2013 -0400
> # Node ID f3a4a22f8d18a916f9faa48b6724a0ac1deab0f3
> # Parent  f1b096a613612935b9b556b25b33c32a29f75f67
> run-tests: minimum changes required to make run-tests work in python3
> 
> This is just doing the dumbest thing possible and assumes test
> input/output is all utf-8[0]. This works for now, at least for the simple
> tests I'm interested in trying to run, so I'm calling it progress
> until I have to come back and figure out something smarter.
> 
> With these changes in place, all tests continue to pass on python2,
> and you can run tests on python3 by running 2to3 over run-tests.py and
> killdaemons.py. At that point, demandimport breaks on python3, causing
> all tests to fail, but at least it's some progress.

All seems sensible to me. Would it be worthwhile for us to throw some effort into improving 2to3 if we want to continue down this path? (Or perhaps you're already on that...)

pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
Kevin R. Bullock



More information about the Mercurial-devel mailing list