[PATCH 2 of 5] shelve: add a shelve extension to save/restore working changes

David Soria Parra dsp at experimentalworks.net
Fri Sep 27 09:37:01 CDT 2013

On 09/18/2013 08:04 PM, Pierre-Yves David wrote:
>> +
>> +    try:
>> +        user = repo.ui.username()
>> +    except util.Abort:
>> +        user = 'shelve at localhost'
> elsewhere in Mercurial, the usename is a strong requirement ? Why isn't
> it the case here ?
> (and additional question, why shelve have no -u argument ?)

Changing the username isn't useful for the user unless we intentionally
want to be able to have users merge the bundle into their repository as
a commit. atm it's only a temporary storage and the username will never
make it's way into the repository. We use --user only for commits that
can make it into the repository (mq, etc). I think a fallback using a
dummy user is okay for shelve in order to avoid confusion ("why do i
need a proper user setup for shelving, what does the --user option do
anyway in shelve?")


More information about the Mercurial-devel mailing list