[PATCH 2 of 4] bundle2: introduce a bundleoperation object

[David Soria Parra]

pierre-yves.david at ens-lyon.org writes:

> # HG changeset patch
> # User Pierre-Yves David <pierre-yves.david at fb.com>
> # Date 1396502684 25200
> #      Wed Apr 02 22:24:44 2014 -0700
> # Node ID d47181150c1edace8a5e5da51e99dffe17d52407
> # Parent  71c310363488940c451912d3d68492e2d5fb7eea
> bundle2: introduce a bundleoperation object
>
> This object is responsible of store sta

I am wondering for what this object is responsible, because that
sentences is cut off.

> This object will hold all data and state gathered through the processing of a
> bundle. This will allow:
>
> - each handler to be aware of the thing unbundled so far
> - the caller to retrieve data about the execution
> - bear useful object and logic (like repo, transaction)
> - bear possible bundle2 reply triggered by the unbundling.
>
> For now the object is very simple but it will grow at the same time than the
> bundle2 implementation.

"grow with the bundle2 implementation"

>
> diff --git a/mercurial/bundle2.py b/mercurial/bundle2.py
> --- a/mercurial/bundle2.py
> +++ b/mercurial/bundle2.py
> @@ -181,10 +181,31 @@ def parthandler(parttype):
>          assert lparttype not in parthandlermapping
>          parthandlermapping[lparttype] = func
>          return func
>      return _decorator
>  
> +class bundleoperation(object):
> +    """an object that represent a single bundle processing

English sentences usually start with an uppercase character: an -> An

> +
> +    It purpose is to carry unbundle related objects and states.
> +
> +    A new should be created at the begining of each bundle processing. the

See above. the -> he

> +    object is to be return by the processing function.

is to be -> must be?

> +
> +    The object have very little content now it will ultimatly contains:

The object "has" (3rd person)