[PATCH RFC] color: rename 'label' template function to 'color'

Sean Farley sean.michael.farley at gmail.com
Sun Apr 6 21:35:27 CDT 2014


Sean Farley <sean.michael.farley at gmail.com> writes:

> # HG changeset patch
> # User Sean Farley <sean.michael.farley at gmail.com>
> # Date 1396670819 18000
> #      Fri Apr 04 23:06:59 2014 -0500
> # Node ID aa43236b2340fadf49b087929f0e5ed514ec0c60
> # Parent  c7ceae0faf6997ff3c262a0b641719b6fd357055
> color: rename 'label' template function to 'color'
>
> Previously, the name 'label' as a template function was not that
> descriptive. We change the name to 'color' now to describe exactly what it
> does. Future patches will augment the ability of this function to accept a
> color name as an argument.
>
> This rename is justified because 'label' is a no-op in core Mercurial and even
> with the color extension enabled, it is still not used when output is
> redirected (such as scripts).

This is written as a statement for purposes of a patch description but
is really a question asking if this is ok.


More information about the Mercurial-devel mailing list