[PATCH 1 of 5] color: extract method for determining a valid effect

[Sean Farley]

Matt Mackall <mpm at selenic.com> writes:

> On Mon, 2014-04-07 at 15:58 -0500, Sean Farley wrote:
>> # HG changeset patch
>> # User Sean Farley <sean.michael.farley at gmail.com>
>> # Date 1396902796 18000
>> #      Mon Apr 07 15:33:16 2014 -0500
>> # Node ID 07cabc89783a8ce2fd224b2955fcce6e9ab90c38
>> # Parent  12f161f08d744f0e4b6eef9c905670afb5c24dd4
>> color: extract method for determining a valid effect
>> 
>> diff --git a/hgext/color.py b/hgext/color.py
>> --- a/hgext/color.py
>> +++ b/hgext/color.py
>> @@ -309,10 +309,19 @@ def render_effects(text, effects):
>>  
>>  def extstyles():
>>      for name, ext in extensions.extensions():
>>          _styles.update(getattr(ext, 'colortable', {}))
>>  
>> +def valid_effect(effect):
>
> http://mercurial.selenic.com/wiki/CodingStyle?action=show&redirect=BasicCodingStyle#Naming_conventions

Fair enough. Though the other method names have underscores in them,
I'll remove it and resend.