[PATCH 1 of 8] bundle2: extract stream//unpack logic in an unpackermixin

Pierre-Yves David pierre-yves.david at ens-lyon.org
Sat Apr 12 23:05:17 CDT 2014



On 04/12/2014 06:14 PM, Olle wrote:
>
>
>
> On Sun, Apr 13, 2014 at 12:08 AM, <pierre-yves.david at ens-lyon.org
> <mailto:pierre-yves.david at ens-lyon.org>> wrote:
>
>     # HG changeset patch
>     # User Pierre-Yves David <pierre-yves.david at fb.com
>     <mailto:pierre-yves.david at fb.com>>
>     # Date 1397243994 14400
>     #      Fri Apr 11 15:19:54 2014 -0400
>     # Node ID 24f7528f409dff53d1372df5015e59d331983311
>     # Parent  3d38ebb586fe5a3bb74c68c2464f948ede39e63d
>     bundle2: extract stream//unpack logic in an unpackermixin
>
>     The coming `unbundlepart` will need the same kind of method than
>     `unbundle20`
>     for unpacking data from the stream. We extract them into a mixin
>     class before
>     the creation of `unbundlepart`.
>
>     diff --git a/mercurial/bundle2.py b/mercurial/bundle2.py
>     --- a/mercurial/bundle2.py
>     +++ b/mercurial/bundle2.py
>     @@ -371,35 +371,42 @@ class bundle20(object):
>                       value = urllib.quote(value)
>                       par = '%s=%s' % (par, value)
>                   blocks.append(par)
>               return ' '.join(blocks)
>
>     -class unbundle20(object):
>     -    """interpret a bundle2 stream
>     +class unpackermixing(object):
>
> I think you mean mixin here

facepalm

-- 
Pierre-Yves


More information about the Mercurial-devel mailing list