[PATCH 8 of 8 STABLE] revset: drop spanset._contained

Durham Goode durham at fb.com
Mon Apr 28 21:29:13 CDT 2014


On 4/28/14, 5:48 PM, "pierre-yves.david at ens-lyon.org"
<pierre-yves.david at ens-lyon.org> wrote:

># HG changeset patch
># User Pierre-Yves David <pierre-yves.david at fb.com>
># Date 1398494304 25200
>#      Fri Apr 25 23:38:24 2014 -0700
># Branch stable
># Node ID 093d17f55d0d46a55cddb5430c0e4f4a3641477b
># Parent  00d62213d5785c5875d2251d3cde737b994ca1c6
>revset: drop spanset._contained
>
>All its users inlined it for performance reasons.
>
>diff --git a/mercurial/revset.py b/mercurial/revset.py
>--- a/mercurial/revset.py
>+++ b/mercurial/revset.py
>@@ -2761,14 +2761,10 @@ class spanset(_orderedsetmixin):
> 
>     def descending(self):
>         if self._start < self._end:
>             self.reverse()
> 
>-    def _contained(self, rev):
>-        return ((self._end < rev <= self._start)
>-                 or (self._start <= rev < self._end))
>-
>     def __iter__(self):
>         if self._start <= self._end:
>             iterrange = xrange(self._start, self._end)
>         else:
>             iterrange = xrange(self._start, self._end, -1)

This series looks good to me.  Leaving for Matt to queue since it¹s stable
and late in the freeze.



More information about the Mercurial-devel mailing list