[PATCH 01 of 15] cmdutil: introduce 'editform' to distinguish the purpose of commit text editing

Pierre-Yves David pierre-yves.david at ens-lyon.org
Mon Aug 4 21:50:09 CDT 2014



On 08/02/2014 06:02 AM, FUJIWARA Katsunori wrote:
> # HG changeset patch
> # User FUJIWARA Katsunori <foozy at lares.dti.ne.jp>
> # Date 1406983586 -32400
> #      Sat Aug 02 21:46:26 2014 +0900
> # Node ID 1751cb1a4bd3f8d50b498454e72155b3fc509d00
> # Parent  3467cf39aae688e844d5c1c22b7daa85c590bef9
> cmdutil: introduce 'editform' to distinguish the purpose of commit text editing

I love this series but:

* you should document this changeset with example of what is kind of 
value your expect. this will help making its purpose clear.

I think the format for core command should be

   CORE.<command>.<route>

to match:

   <extension>.<command>.<route>

This will avoid silly collision when core introduce a command that match 
an extension name.

> This information will be used to switch '[committemplate] changeset'
> definition according to its purpose in the subsequent patch.
>
> This information also makes it easier to hook commit text editing only
> in the specific cases.

♥

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list