[PATCH 15 of 15] cmdutil: use '[committemplate]' section like as map file for style definition

Matt Mackall mpm at selenic.com
Tue Aug 5 15:03:02 CDT 2014

On Mon, 2014-08-04 at 20:06 -0700, Pierre-Yves David wrote:
> g
> On 08/02/2014 06:02 AM, FUJIWARA Katsunori wrote:
> > # HG changeset patch
> > # User FUJIWARA Katsunori <foozy at lares.dti.ne.jp>
> > # Date 1406983587 -32400
> > #      Sat Aug 02 21:46:27 2014 +0900
> > # Node ID ee832d729d973bd5e60f2bafcd3df559293602ab
> > # Parent  db6e59e045dec018344a2eff0c854d446a2bcffa
> > cmdutil: use '[committemplate]' section like as map file for style definition
> I love this series and its looks overall good (but for previously made 
> comment)
> I will happily push a V2 with:
> - Improvement docstring for the new argument
> - core command prefixed with `core` (or an explanation of why this would 
> be a terrible idea)

I've gone ahead and taken this series as is. I'm not terribly concerned
by the namespace collision thing, not enough to insist on adding 'core'
everywhere. The docstring thing can be fixed by followup patch,
definitely not worth another 15 patches in my mailbox.

FYI, I'd rather this sort of series be structured/sent as 2/3 patches to
add the core feature + N patches to add all the users after the core
bits had been accepted. Long series with tricky bits mixed in = bottom
of review stack.

Other things I'd like to see happen here:
- send full HGEDITFORM environment variable to $EDITOR if it wants to do
its own templating of some sort
- have a form for merge commits

Mathematics is the supreme nostalgia of our time.

More information about the Mercurial-devel mailing list