[PATCH stable] histedit: use str.startswith, remove duplicate line and extra blank line

Matt Mackall mpm at selenic.com
Thu Aug 7 15:01:55 CDT 2014


On Thu, 2014-08-07 at 15:17 -0400, adgar at google.com wrote:
> # HG changeset patch
> # User Mike Edgar <adgar at google.com>
> # Date 1407427942 14400
> #      Thu Aug 07 12:12:22 2014 -0400
> # Node ID 4fc87e9ba34429406ff29446c5fdd8b5a17687e1
> # Parent  ba5fc3f81f1588507a5a84ac2b43679705ceec7b
> histedit: use str.startswith, remove duplicate line and extra blank line

FYI, you've flagged this for stable, but the goal of stable is to
maximize the improvement/risk ratio. "Code cleanups" like this can only
negatively impact that ratio.. by accidentally introducing breakage.

http://mercurial.selenic.com/wiki/TimeBasedReleasePlan#Rules_for_code_freeze_and_stable_branch_commits

If you're going to tidy up histedit, it's best to group all your related
changes:

- whitespace changes (can all be in one patch)
- pure code movement
- typo fixes
- etc..

If I can look at each hunk of your patch and say "yes, that obviously
matches the one line description of this patch", then that's a good sign
you're doing it right.

(You're going to discover we really sweat the small stuff like this - it
reduces friction later when we get to the big stuff.)

I actually just took a moment to do:

$ emacs $(hg locate 'set:**.py and grep("(?m)\n\n\n\n")')

..to globally nuke some excessive vertical whitespace.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list