[PATCH 4 of 8 RFC] basectx: cache filectx generation for all contexts

Matt Mackall mpm at selenic.com
Thu Aug 7 16:47:14 CDT 2014


On Thu, 2014-08-07 at 14:52 -0500, Sean Farley wrote:
> # HG changeset patch
> # User Sean Farley <sean.michael.farley at gmail.com>
> # Date 1403899852 18000
> #      Fri Jun 27 15:10:52 2014 -0500
> # Node ID 6f2891408ace48a633862fd2b3dfb0ade1ab99db
> # Parent  124225c16d40a0c2707e346c67e2a7a332ca0509
> basectx: cache filectx generation for all contexts
> 
> Previously, filecontexts are generated on the fly but not cached. We need to
> keep them around if we're going to allow the data inside to be changed.

Seems problematic. In a case like convert, we'll potentially queue up
many megabytes in our cache (possibly larger than memory for initial
commits!), even though we have the ability to rebuild each file as
needed because we have a callable.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list