[PATCH 1 of 3] repoview: split _gethiddenblockers
Pierre-Yves David
pierre-yves.david at ens-lyon.org
Thu Aug 7 22:41:40 CDT 2014
On 08/07/2014 11:08 AM, David Soria Parra wrote:
> # HG changeset patch
> # User David Soria Parra <davidsp at fb.com>
> # Date 1407356764 25200
> # Wed Aug 06 13:26:04 2014 -0700
> # Node ID 4ac33b2438c3d50d5f1f21423f0a51ed32d12994
> # Parent 4354b1e35f533f72d5b6ccc76e8bc742f8cb5257
> repoview: split _gethiddenblockers
>
> Split up _gethiddenblockers into two categories: (1) blockers that solely rely
> on the contents of obstore and are visible children of hidden changsets. (2)
> "dynamic" blockers, appearing by having wd parents, bookmarks or tags pointing
> to hidden changesets.
>
> We assume that (1) doesn't change often and can be easily cached with a good
> invalidation strategy. (2) change often, but barely produce blockers, so we
> can recompute them if necessary.
I really love the idea. However, you have to call the extracted function
too. So that the code keep gathering both after this patches.
This -would- be a good place to introduce the two pass filtering to
minimize next patch churn.
--
Pierre-Yves David
More information about the Mercurial-devel
mailing list