[PATCH 5 of 6] pushbookmark: split an ultra long line in a saner version

Pierre-Yves David pierre-yves.david at ens-lyon.org
Mon Aug 18 17:51:11 CDT 2014



On 08/18/2014 03:48 PM, Augie Fackler wrote:
> On Mon, Aug 18, 2014 at 02:50:03PM -0700, Pierre-Yves David wrote:
>> # HG changeset patch
>> # User Pierre-Yves David <pierre-yves.david at fb.com>
>> # Date 1408150974 25200
>> #      Fri Aug 15 18:02:54 2014 -0700
>> # Node ID 8db10be23d42b45f7f86cecad186858059ed91f6
>> # Parent  35c3e0ecdddf3d777f48f978788c5e418967f0f2
>> pushbookmark: split an ultra long line in a saner version
>
> Queueing the others, but I think I prefer something that would at least check that the tuple length stayed constant. Thoughts?

meh, not sure what this brings but complexity in the code.

If someone change the function signature in core it is his duty to 
update all call site. And hopefully anything too crazy wil be caught by 
the tests.

--
Pierre-Yves David


More information about the Mercurial-devel mailing list