[PATCH 2 of 4] merge: use file context objects instead of acting directly on localrepo

Pierre-Yves David pierre-yves.david at ens-lyon.org
Tue Aug 19 01:02:13 CDT 2014



On 08/18/2014 07:42 PM, Sean Farley wrote:
> # HG changeset patch
> # User Sean Farley <sean.michael.farley at gmail.com>
> # Date 1406339242 18000
> #      Fri Jul 25 20:47:22 2014 -0500
> # Node ID d1a21cc0bc4ba5764a1f8760fd041a91939b4d00
> # Parent  594d00e49cea6cd2ebb92c0570e7502f8797e232
> merge: use file context objects instead of acting directly on localrepo

Can you remind me what is the motivation behind have those methods 
(write/removes) on the filectx instead of the changectx itself?

Given the potential cycle between filectx and changectx, I'm not sure 
the "methods on filectx" way can fly easily.

Small nits: We could also use one function update per patch for 
readability purpose.

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list