[PATCH 1 of 6] util: add event handling mechanism

[Augie Fackler]

On Mon, Aug 18, 2014 at 10:53:21PM -0700, Gregory Szorc wrote:
> On 8/18/2014 10:30 PM, Gregory Szorc wrote:
> > # HG changeset patch
> > # User Gregory Szorc <gregory.szorc at gmail.com>
> > # Date 1408422497 25200
> > #      Mon Aug 18 21:28:17 2014 -0700
> > # Node ID 110ff56e99e2ccff03841cc8baeed7f14c35f69b
> > # Parent  8dda6f6ff564d8fe6ac7b8ce4c74eb9bfb5de14a
> > util: add event handling mechanism
>
> > diff --git a/tests/test-eventmanager.py b/tests/test-eventmanager.py
> > new file mode 100644
> > --- /dev/null
> > +++ b/tests/test-eventmanager.py
> > @@ -0,0 +1,109 @@
> > +from mercurial.util import event, eventmanager, safehasattr
> > +
> > +import unittest
> > +import silenttestrunner
> > +
> > +class testeventmanager(unittest.TestCase):
> > +    def test_eventsimple(self):
>
> test-check-commit-hg.t doesn't like this commit because it is
> introducing a function with underscores. But I just stole this naming
> convention from other unittest-based .py tests. I'm not sure who is in
> the wrong here.
>
> Dropping the _ still runs the tests.

I'm going to claim that test-check-commit-hg.t is too picky here, and
that consistency with the other unittest-derived testcases is
worthwhile.

A fix doesn't seem immediately obvious, but I'm also happy to just
ignore it for now.

> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel