[PATCH 2 of 2 V2] clone: for local clones, copy over filtered branchcaches as well (issue4286)

[Pierre-Yves David]

On 08/21/2014 04:25 PM, Siddharth Agarwal wrote:
> # HG changeset patch
> # User Siddharth Agarwal <sid0 at fb.com>
> # Date 1408662329 25200
> #      Thu Aug 21 16:05:29 2014 -0700
> # Node ID cfc686b2b6d22888aeb8621c3e388005001f4caa
> # Parent  d5c551bf9d58912c8c084b5abce76b606c870eb6
> clone: for local clones, copy over filtered branchcaches as well (issue4286)
>
> Local clones copy/hardlink over files directly, so the branchcaches should all
> be valid. There's a slight chance that a read operation would update one of the
> branchcaches, but we hold a lock over the source repo so they shouldn't cause
> an invalid branchcache to be copied over, just a different, valid one.

Copying an invalid branch cache (instead of non cache) is not a huge 
deal as the cache would be detected as invalid and recomputed.

-- 
Pierre-Yves David