[PATCH] changegroup: rename bundle-related functions and classes

sune.foldager at me.com sune.foldager at me.com
Sun Aug 31 05:59:50 CDT 2014


On 31/08/2014, at 12:53, Kevin Bullock <kbullock+mercurial at ringworld.org> wrote:

> On Aug 31, 2014, at 12:17 PM, sune.foldager at me.com wrote:
> 
>>> -class unbundle10(object):
>>> -    deltaheader = _BUNDLE10_DELTA_HEADER
>>> +class changegroupv1unpacker(object):
>>> +    deltaheader = _CHANGEGROUPV1_DELTA_HEADER
>> 
>> I don’t really like the names changegroupv1unpacker and packer too much, but at least it describes what it does. Better names are welcome :)
> 
> What about a scheme like the one Pierre-Yves just introduced in obsolete--something like `cg1unpacker`? I'm fine with the existing one, just an idea.

Yeah, I like that; short and neat, and already used in several places. The reason for the ‘1’ in the names is because I have another patch t add a changegroup 2 format, which supports generaldelta :)

-Sune


More information about the Mercurial-devel mailing list