[PATCH 08 of 17] rebase: instead of using >= 0, use the slightly more meaningful > nullrev
Pierre-Yves David
pierre-yves.david at ens-lyon.org
Mon Dec 1 07:17:18 UTC 2014
On 11/30/2014 11:08 AM, Mads Kiilerich wrote:
> # HG changeset patch
> # User Mads Kiilerich <madski at unity3d.com>
> # Date 1417374421 -3600
> # Sun Nov 30 20:07:01 2014 +0100
> # Node ID 29e5055154d72cee53986e57b50b6ee6a999bd88
> # Parent 848717d552179b3679951aefc0b28235784471ba
> rebase: instead of using >= 0, use the slightly more meaningful > nullrev
Meh, this kind of contradict you previous patch.
> Avoid using a hardcoded number - use the defined constant.
Moreover, >= 0 is not a random number. It state "number is positive". I
woudl keep it as such.
--
Pierre-Yves David
More information about the Mercurial-devel
mailing list