[PATCH 4 of 4] bundle2-push: provide transaction to reply unbundler

Durham Goode durham at fb.com
Tue Dec 2 00:34:26 UTC 2014


On 11/25/14 10:26 AM, Eric Sumner wrote:
> # HG changeset patch
> # User Eric Sumner <ericsumner at fb.com>
> # Date 1416613838 28800
> #      Fri Nov 21 15:50:38 2014 -0800
> # Node ID 99c668568ef7ecc0f6fd1ca7a3f9dc6de91d176e
> # Parent  46994128747aa4bc3057c7fbdbe19f4734cd48ab
> bundle2-push: provide transaction to reply unbundler
>
> This patch series is intended to allow bundle2 push reply part handlers to
> make changes to the local repository; it has been developed in parallel with
> an extension that allows the server to rebase incoming changesets while applying
> them.
>
> This diff adds an experimental config option "bundle2.pushback" which provides
> a transaction to the reply unbundler during a push operation.  This behavior is
> opt-in because of potential security issues: the response can contain any part
> type that has a handler defined, allowing the server to make arbitrary changes
> to the local repository.
>
> +
> +  $ cat >> $HGRCPATH <<EOF
> +  > [ui]
> +  > ssh = python "$TESTDIR/dummyssh"
> +  > username = nobody <no.reply at example.com>
> +  > EOF
> +  $ alias commit='hg commit -d "0 0" -A -m'
> +  $ alias log='hg log -G -T "{desc} [{phase}:{node|short}]"'
> +

Generally looks good.  Pushed to clowncopter with some changes to these 
uses of 'alias' since they cause test-check-code-hg failures.


More information about the Mercurial-devel mailing list