[PATCH 1 of 2] log: display closing-branch nodes as "_" (BC)

[Pierre-Yves David]

On 11/25/2014 08:04 AM, Jordi Gutiérrez Hermoso wrote:
> On Mon, 2014-11-24 at 15:16 -0800, Pierre-Yves David wrote:
>>
>> On 11/24/2014 01:48 PM, Jordi Gutiérrez Hermoso wrote:
>>> diff --git a/mercurial/cmdutil.py b/mercurial/cmdutil.py
>>> --- a/mercurial/cmdutil.py
>>> +++ b/mercurial/cmdutil.py
>>> @@ -1922,6 +1922,8 @@ def displaygraph(ui, dag, displayer, sho
>>>                char = '@'
>>>            elif ctx.obsolete():
>>>                char = 'x'
>>> +        elif ctx.closesbranch():
>>> +            char = '_'
>>
>> This will probably also trigger for re-opened branches. you should only
>> probably restrict this to real closed heads.
>
> I thought about that, but I decided against it. It will be very
> obvious graphically when a closing-branch commit gets reopened,

Given how low the underscore char is I disagree with the "obvious" part.

> and it would still be nice to see graphically that it was closed and then
> reopened.

I've already seen and tested such approach (reopening) and I find is 
confusing.

-- 
Pierre-Yves David