[PATCH 2 of 4] obsstore: disable garbage collection during initialisation (issue4456)

[Pierre-Yves David]

On 11/30/2014 10:27 PM, Martin von Zweigbergk wrote:
>
>
> On Sat Nov 29 2014 at 11:47:09 PM Pierre-Yves David
> <pierre-yves.david at ens-lyon.org <mailto:pierre-yves.david at ens-lyon.org>>
> wrote:
>
>
>
>     On 11/29/2014 10:29 PM, Martin von Zweigbergk wrote:
>      >
>      >     The provide and
>      >     interesting speedup (25%).
>      >
>      >     On my 58758 markers repo:
>      >     before: 0.468247 seconds
>      >     after:  0.344362 seconds
>      >
>      >
>      > Do you see similar values from 'time hg ...'? Without trying to
>      > understand the patch, it sounds like you could just be moving the
>     GC out
>      > of the method that's being timed. I just want to make sure it's an
>      > overall gain.
>
>     I do see similar gain, the overall time is much more unstable, but I get
>     about the same benefit 0.05s
>
>
> 0.05s is less than 0.12s and more like 10-15% than 25%, assuming you're
> still talking about the same baseline of ~0.46s. It's still a
> significant speedup, so it seems worthwhile, but you may want to include
> the "end-to-end" times in the description.

I cannot read… I though the speedup was 8 so 5 is not too bad.

I did some more time testing and I cannot see a time different form 
small operation like 'hg id'. So we should probably drop that patches 
from the series (the rest is okay)

-- 
Pierre-Yves David