[PATCH 3 of 3] patchbomb: introduce a 'patchwork.confirm' option

[Mads Kiilerich]

On 12/03/2014 04:12 AM, Pierre-Yves David wrote:
> # HG changeset patch
> # User Pierre-Yves David <pierre-yves.david at fb.com>
> # Date 1417570521 28800
> #      Tue Dec 02 17:35:21 2014 -0800
> # Node ID 20e66de4913566197f0066f5835086c844deb401
> # Parent  d943db1f1f572bf3c01b8ca6b5e728ebc30649aa
> patchbomb: introduce a 'patchwork.confirm' option
>
> When set to true, this option will make patchbomb always ask for confirmation
> before sending the email. Confirmation is a powerful way to prevent stupid
> mistake when the sending patches.
>
> This should let me get ride of my global alias adding
> --confirm to hg email.
>
> I know that some people may get bitten when moving from a machine with confirm
> configured  to machine where it is not. But I think it is still worth the risk.

I would certainly enable this and take the risk of not minimizing the 
risk everywhere.

Somewhat related: I would also like to add a similar option to push, 
kind of like 'hg outgoing && hg bundle && echo bundle info && read ok && 
hg push' but using the same discovery and bundle for all operations.

/Mads