[PATCH 2 of 3] patchbomb: add a 'patchbomb.intro' option

Pierre-Yves David pierre-yves.david at ens-lyon.org
Wed Dec 3 17:49:22 CST 2014



On 12/02/2014 09:05 PM, Ryan McElroy wrote:
> Just typos and nits, inline.
>
>> -----Original Message-----
>> From: Mercurial-devel [mailto:mercurial-devel-bounces at selenic.com] On
>> Behalf Of Pierre-Yves David
>> Sent: Tuesday, December 2, 2014 7:12 PM
>> To: mercurial-devel at selenic.com
>> Cc: Pierre-Yves David
>> Subject: [PATCH 2 of 3] patchbomb: add a 'patchbomb.intro' option
>>
>> # HG changeset patch
>> # User Pierre-Yves David <pierre-yves.david at fb.com> # Date 1417569892
>> 28800
>> #      Tue Dec 02 17:24:52 2014 -0800
>> # Node ID d943db1f1f572bf3c01b8ca6b5e728ebc30649aa
>> # Parent  f5b943c897859b30aa362e0a7c61daa14e928a57
>> patchbomb: add a 'patchbomb.intro' option
>>
>> This option allows to control the default behavior for including an
>> introduction message. This would avoid having to tirelessly skip the intro for
>> people contributing to mercurial.
>>
>> The three possibles values are:
>> - always,
>> - auto (default, current behavior),
>> - never.
>>
>> I was thinking of ("true", "false", "") (empty value being auto) but I ruled it
>> out as too confusing.
>>
>> This new config option reuse the pre-existing 'patchnbomb' section.
>
> Whoops, typo: 'patchnbomb' should be 'patchbomb'


Whoops right.

>
>>
>> diff --git a/hgext/patchbomb.py b/hgext/patchbomb.py
>> --- a/hgext/patchbomb.py
>> +++ b/hgext/patchbomb.py
>> @@ -41,10 +41,19 @@ changesets as a patchbomb.
>>   You can also either configure the method option in the email section  to be a
>> sendmail compatible mailer or fill out the [smtp] section so  that the
>> patchbomb extension can automatically send patchbombs  directly from the
>> commandline. See the [email] and [smtp] sections in
>>   hgrc(5) for details.
>> +
>> +You can control the default inclusion of an introduction message with
>> +the ``patchbomb.intro`` configuration option. The configuration is
>> +always overwritten by command line flags like --intro and --desc::
>> +
>> +  [patchbomb]
>> +  intro=auto   # include introduction message if more than 1 patch (default)
>> +  intro=never  # never included an introduction message  intro=always #
>> + always include an introduction message
>>   '''
>
> Style nit: It feels to me that intro=always should start on its own line

It does have it own line. Not sure what your mailer is doing wrong here.

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list