[PATCH] log: fix log -f slow path to actually follow history

Durham Goode durham at fb.com
Fri Dec 5 18:05:45 CST 2014


On 12/5/14 3:22 PM, Durham Goode wrote:
>
> On 12/5/14 3:19 PM, Durham Goode wrote:
>>
>> On 12/5/14, 2:56 PM, "Pierre-Yves David" 
>> <pierre-yves.david at ens-lyon.org>
>> wrote:
>>
>>>
>>> On 12/05/2014 02:54 PM, Durham Goode wrote:
>>>> # HG changeset patch
>>>> # User Durham Goode <durham at fb.com>
>>>> # Date 1417818452 28800
>>>> #      Fri Dec 05 14:27:32 2014 -0800
>>>> # Node ID 96d916622019f448bd012884ee4fd78fe8dc63ba
>>>> # Parent  406dfc63a1ad71213dccc1a45de99a3c5d5ac460
>>>> log: fix log -f slow path to actually follow history
>>>>
>>>> log -f was using ':.' instead of '::.' so it wasn't actually following
>>>> history.
>>>> This fixes it and adds a test. It's been broken for years, so I guess
>>>> it wasn't
>>>> that big of a deal...
>>> good catch.
>>>
>>> Does this open us to linkrev related bug when using it on a file?
>> Good question.  I updated the test to check for that, and it doesn¹t 
>> seem
>> to affect file log traversals when the linkrev commit is not an 
>> ancestor.
>> I¹ll resend with the new test.
>>
>>
> Actually, I lied.  It does affect it :(  My test was just wrong. 
> Sigh.  K I'll figure out a fix and resend.
Good news everyone! hg log -f <file> was broken for linkrevs even 
without my change!  So I'll send my patch out with a better test and 
will log a bug about log -f <file> being broken, since it will require a 
more indepth fix around linkrevs.


More information about the Mercurial-devel mailing list