[PATCH 4 of 4] transaction: remove the 'onabort' mechanism

[Pierre-Yves David]

On 12/10/2014 08:26 AM, Gregory Szorc wrote:
> On 12/8/14 5:26 PM, Pierre-Yves David wrote:
>> # HG changeset patch
>> # User Pierre-Yves David <pierre-yves.david at fb.com>
>> # Date 1417729966 28800
>> #      Thu Dec 04 13:52:46 2014 -0800
>> # Node ID 980580522580073e8c8e5ea1b7f765dca8abd53a
>> # Parent  6187b0dbeaf5ce313b6dae85f1f01c3ec67e866f
>> transaction: remove the 'onabort' mechanism
>>
>> It has no known users. If someones needs similar functionality, a new
>> 'addabort'
>> method similar to 'addfinalize' should be added.
>
> You just broke Facebook's hgsql extension:
> https://bitbucket.org/facebook/hgsql/src/b8ec4d48df21025f74d3b892408af91200d91ac6/hgsql.py?at=default#cl-289

Good catch, thanks.

> On a related note, Mozilla also wants to hook other transaction-based
> systems up to Mercurial's transaction object. I was kinda relying on the
> existence of _abort() to handle rollback. I guess I'll have to write
> 'addabort' patches now :/

Yup, I think it is a more consistent and powerful path.

-- 
Pierre-Yves David