[PATCH 4 of 4] transaction: remove the 'onabort' mechanism

Durham Goode durham at fb.com
Wed Dec 10 19:05:03 CST 2014


On 12/10/14 4:34 PM, Pierre-Yves David wrote:
>
> On 12/10/2014 08:26 AM, Gregory Szorc wrote:
>> On 12/8/14 5:26 PM, Pierre-Yves David wrote:
>>> # HG changeset patch
>>> # User Pierre-Yves David <pierre-yves.david at fb.com>
>>> # Date 1417729966 28800
>>> #      Thu Dec 04 13:52:46 2014 -0800
>>> # Node ID 980580522580073e8c8e5ea1b7f765dca8abd53a
>>> # Parent  6187b0dbeaf5ce313b6dae85f1f01c3ec67e866f
>>> transaction: remove the 'onabort' mechanism
>>>
>>> It has no known users. If someones needs similar functionality, a new
>>> 'addabort'
>>> method similar to 'addfinalize' should be added.
>>
>> You just broke Facebook's hgsql extension:
>> https://urldefense.proofpoint.com/v1/url?u=https://bitbucket.org/facebook/hgsql/src/b8ec4d48df21025f74d3b892408af91200d91ac6/hgsql.py?at%3Ddefault%23cl-289&k=ZVNjlDMF0FElm4dQtryO4A%3D%3D%0A&r=pHOG6Hz51SkYmYr%2FxoTFzw%3D%3D%0A&m=CijdtF%2BO4%2FdAmOJ1rMXlyKKE7tw6BqyH%2F4%2FP3fRQ7uU%3D%0A&s=78f2dbce723513eeb22dbc3bdcc9be6a6a049c462a23345b57a483099ba466fd 
>>
>
> Good catch, thanks.
I don't think it broke hgsql.  hgsql wraps transaction._abort which 
wasn't touched by your changes.  Though I haven't actually tried to run 
hgsql with the new mercurial bits yet.


More information about the Mercurial-devel mailing list