[PATCH 4 of 8 V3] subrepo: store the ui object in the base class
Matt Harbison
mharbison72 at gmail.com
Fri Dec 12 19:48:58 CST 2014
On Fri, 12 Dec 2014 12:59:21 -0500, Martin von Zweigbergk
<martinvonz at google.com> wrote:
> On Thu Dec 11 2014 at 7:36:10 PM Matt Harbison <mharbison72 at gmail.com>
> wrote:
>
>> # HG changeset patch
>> # User Matt Harbison <matt_harbison at yahoo.com>
>> # Date 1417036418 18000
>> # Wed Nov 26 16:13:38 2014 -0500
>> # Node ID 71bacffdfe45b9b262e8a3c7260375e1b0f0b29c
>> # Parent da5bde55b5296f0cce6dd7582c0c5d1edb323ec8
>> subrepo: store the ui object in the base class
>>
>> This will be used in the next patch to print a warning from the base
>> class. It
>> seems better than having to explicitly pass it to a new method, since a
>> lot of
>> existing methods also require it.
>>
>
> Is it worth updating those existing methods?
I think it is, but I assume it would have been rejected if I changed the
other methods in this patch, and didn't want to divert this series into
something else. I'll take a look at it this weekend if I have time.
--Matt
More information about the Mercurial-devel
mailing list