[PATCH] spelling: fixes from proofreading of spell checker issues

Mads Kiilerich mads at kiilerich.com
Sun Dec 14 08:33:48 CST 2014


On 12/13/2014 09:06 PM, Pierre-Yves David wrote:
> On 12/12/2014 06:14 PM, Mads Kiilerich wrote:
>> # HG changeset patch
>> # User Mads Kiilerich <madski at unity3d.com>
>> # Date 1397767658 -7200
>> #      Thu Apr 17 22:47:38 2014 +0200
>> # Node ID 4901e6ad8a11fb76449599a0314040dd338346c7
>> # Parent  416c133145ee78c8e83865b7370e185eed69c1be
>> spelling: fixes from proofreading of spell checker issues
>>
>> diff --git a/hgext/largefiles/lfutil.py b/hgext/largefiles/lfutil.py
>> --- a/hgext/largefiles/lfutil.py
>> +++ b/hgext/largefiles/lfutil.py
>> @@ -571,6 +571,6 @@ def getstatuswriter(ui, repo, forcibly=N
>>           return repo._lfstatuswriters[-1]
>>       else:
>>           if forcibly:
>> -            return ui.status # forcibly WRITE OUT
>> +            return ui.status
>>           else:
>> -            return lambda *msg, **opts: None # forcibly IGNORE
>> +            return lambda *msg, **opts: None
>
> Not sure why you drop these two out, It should probably be a in a 
> different patch.

These popped up in my checker because of the yelling. Yelling is 
inappropriate. The code here is very simple and more readable and almost 
shorter than the comments. The comments are wrong/misleading - ui.status 
is not forcing any writeout. This is however not something that deserves 
mentioning in the repo history. Thus, I tweaked it quietly. Enough time 
spent on that.

> I've pushed the the clowcopter the rest of the patch and dropped 
> theses two changes.

Thanks.

/Mads



More information about the Mercurial-devel mailing list