[PATCH 2 of 2] manifest: disallow setting the node id of an entry to None

Augie Fackler raf at durin42.com
Mon Dec 15 10:22:06 CST 2014


On Mon, Dec 15, 2014 at 11:20 AM, Martin von Zweigbergk
<martinvonz at google.com> wrote:
> On Mon Dec 15 2014 at 7:23:00 AM Augie Fackler <raf at durin42.com> wrote:
>>
>> +        assert v != None
>
>
> I've been told that one should use the 'is' (or 'is not') operator when
> comparing with None. Not valid in this case?


Nope, completely valid. I blame consistent exposure to C. I'll send a
V2 shortly.


More information about the Mercurial-devel mailing list