[PATCH 1 of 3 RFC] mercurial: add python re2 bindings

Matt Mackall mpm at selenic.com
Mon Dec 15 14:35:17 CST 2014


On Sat, 2014-12-13 at 13:23 -0800, Siddharth Agarwal wrote:
> On 10/13/2014 01:49 PM, Matt Mackall wrote:
> > On Tue, 2014-09-02 at 14:18 -0700, Siddharth Agarwal wrote:
> >> # HG changeset patch
> >> # User Siddharth Agarwal <sid0 at fb.com>
> >> # Date 1409591324 25200
> >> #      Mon Sep 01 10:08:44 2014 -0700
> >> # Node ID f3b022e755dd7cf54e1ded55f0217bb1415348e2
> >> # Parent  a98f6def97bc4b1bc74e37ca207445639e60b1a5
> >> mercurial: add python re2 bindings
> >>
> >> These bindings will enable packagers to build Mercurial with re2 support.
> 
> Following up on this.
> 
> > As mentioned on IRC, I think the right next step here is to try to get
> > this package properly hosted on PyPI
> 
> This is done: https://pypi.python.org/pypi/fb-re2

Nice!

> > and then mention it as
> > recommendation in our package config and docs.
> 
> I'm not exactly sure how to do this -- the extras_require stuff you
> mentioned seems to be setuptools only. The 'requires' that distutils
> supports doesn't appear to be PyPI aware. Did you have any other
> approaches in mind?

I frankly have no idea what the difference is between
setuptools/distutils/eggs/pip/whatnot, and I'm pretty sure I sleep
better because of it. The 'extra_requires' thing is just what I found
when googling for "optional dependency pypi" or somesuch, and not any
arcana I actually possess.

We should probably:

- ask the PyPI community if something suitable exists
- recommend it here: http://mercurial.selenic.com/wiki/Packaging
- ping the Debian/Ubuntu/Redhat/Mac/Windows people about it
- maybe add a hint message to setup.py if it's not found
- mention it in debuginstall

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list