[PATCH] memctx: fix manifest for removed files (issue4470)

Jordi GutiƩrrez Hermoso jordigh at octave.org
Tue Dec 16 13:39:09 CST 2014


On Tue, 2014-12-16 at 10:43 -0500, Augie Fackler wrote:
> # HG changeset patch
> # User Augie Fackler <augie at google.com>
> # Date 1418673654 18000
> #      Mon Dec 15 15:00:54 2014 -0500
> # Node ID 40bd85091fb37fc992e3af2128a8ed31f31a47ff
> # Parent  65c854f92d6ba8861414ff3191182fba28777a82
> memctx: fix manifest for removed files (issue4470)

Nice! Thanks for the fix!

> diff --git a/tests/test-commit.t b/tests/test-commit.t
> --- a/tests/test-commit.t
> +++ b/tests/test-commit.t
> @@ -429,6 +429,68 @@ specific template keywords work well
[snip]
> +  $ cd ..
> +  $ rm -r lol

Maybe remove this last `rm -r` from the test? I had it in the original
repro, but it seems out of place in the test. It's useful to keep the
repos in the tests when doing run-tests.py --keep-tmpdir.

Also, perhaps a better name than "lol" should be used here? I'm kind
of cavalier about my metasyntactic variables.  




More information about the Mercurial-devel mailing list