[PATCH 2 of 3 highlight] test-highlight: expose bug in highlighting file with a formfeed

Pierre-Yves David pierre-yves.david at ens-lyon.org
Tue Dec 16 20:49:52 CST 2014



On 12/16/2014 06:42 PM, Augie Fackler wrote:
>
> On Dec 16, 2014 9:40 PM, "Pierre-Yves David"
> <pierre-yves.david at ens-lyon.org <mailto:pierre-yves.david at ens-lyon.org>>
> wrote:
>  >
>  >
>  >
>  > On 12/16/2014 05:46 PM, Augie Fackler wrote:
>  >>
>  >> # HG changeset patch
>  >> # User Augie Fackler <raf at durin42.com <mailto:raf at durin42.com>>
>  >> # Date 1418765077 18000
>  >> #      Tue Dec 16 16:24:37 2014 -0500
>  >> # Node ID 8d5d9431112bbf7ef694437217f0cd919d6856fd
>  >> # Parent  4f724b91a9ddf395bd756988584f40af6de0cd88
>  >> test-highlight: expose bug in highlighting file with a formfeed
>  >>
>  >> diff --git a/tests/test-highlight.t b/tests/test-highlight.t
>  >> --- a/tests/test-highlight.t
>  >> +++ b/tests/test-highlight.t
>  >> @@ -186,6 +186,105 @@ hgweb filerevision, html
>  >>     </body>
>  >>     </html>
>  >>
>  >> +file with exotic linebreak is not highlighted (currently broken)
>  >
>  >
>  > It is unclear what is broken, could you be a bit more precise in the
> test documentation?
>  >
>  > (yes I'm playing "the guy who did not got the over the phone explanation)
>
> It's fixed in the next patch. Do you really want a resend?

My goal here is to ensure that the next poor soul looking at that test 
have an idea about why it exists. And I think the current description is 
too terse.

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list