[PATCH 3 of 3] highlight: don't highlight files that have fancy linebreaks (issue4291)

Sean Farley sean.michael.farley at gmail.com
Wed Dec 17 22:17:37 CST 2014


Matt Mackall writes:

> On Wed, 2014-12-17 at 12:34 -0800, Pierre-Yves David wrote:
>> 
>> On 12/17/2014 08:16 AM, Augie Fackler wrote:
>> > # HG changeset patch
>> > # User Augie Fackler <raf at durin42.com>
>> > # Date 1418764197 18000
>> > #      Tue Dec 16 16:09:57 2014 -0500
>> > # Node ID 41fb6e503cd6e08fd4dac4a1c3f0a55818708f3f
>> > # Parent  00cf82b3d1453640f454d7f8d628e501228cf391
>> > highlight: don't highlight files that have fancy linebreaks (issue4291)
>> 
>> Theses three are pushed to the clowncopter. Thanks.
>
> As I posted on the issue, I don't like this approach. Unfortunately I
> didn't spot the patches for another 7 hours. We've replaced a mysterious
> missing line with an even more mysterious failure to highlight at all.
> We should instead filter out the problematic non-printing characters; a 
> browser's not going to usefully display them or reliably cut and paste
> them anyway.

Just a project infrastructure question: since both clowncopter and you
use evolve, can't you reject (prune) patches after pulling from
clowncopter?


More information about the Mercurial-devel mailing list