[PATCH] test-check-commit-hg: clarify misleading "commit message rules" error
Martin von Zweigbergk
martinvonz at google.com
Thu Dec 18 18:16:19 UTC 2014
# HG changeset patch
# User Martin von Zweigbergk <martinvonz at google.com>
# Date 1418926298 28800
# Thu Dec 18 10:11:38 2014 -0800
# Node ID 389c3c83692ae3cbc2a1bdc5f9b5368b8db937da
# Parent 3f86fe9bcef0b67d1e5149e66630e46cb515ea90
test-check-commit-hg: clarify misleading "commit message rules" error
The test case doesn't only check the commit message, but also the
patch, which can result in confusing output like
+ Revision df6f06d17100 does not comply to commit message rules
+ ------------------------------------------------------
+ 32: adds double empty line
+
+
even when there are no double blank lines in the commit message. Drop
the "commit message" part to make it less confusing.
diff --git a/tests/test-check-commit-hg.t b/tests/test-check-commit-hg.t
--- a/tests/test-check-commit-hg.t
+++ b/tests/test-check-commit-hg.t
@@ -14,7 +14,7 @@
$ for node in `hg log --rev 'draft() and ::.' --template '{node|short}\n'`; do
> hg export $node | contrib/check-commit > ${TESTTMP}/check-commit.out
> if [ $? -ne 0 ]; then
- > echo "Revision $node does not comply to commit message rules"
+ > echo "Revision $node does not comply to rules"
> echo '------------------------------------------------------'
> cat ${TESTTMP}/check-commit.out
> echo
More information about the Mercurial-devel
mailing list