[PATCH 2 of 6] changelog: branchinfo is a low level function - it should return UTF-8

Matt Mackall mpm at selenic.com
Mon Dec 22 13:51:02 CST 2014


On Sun, 2014-12-14 at 19:34 +0100, Mads Kiilerich wrote:
> # HG changeset patch
> # User Mads Kiilerich <madski at unity3d.com>
> # Date 1418581678 -3600
> #      Sun Dec 14 19:27:58 2014 +0100
> # Node ID 4f99561d776947cc3911b645c485be1bc2cf0c1f
> # Parent  d35c8e8e2c7f980853fc4da0f0e251f8ca197d43
> changelog: branchinfo is a low level function - it should return UTF-8
> 
> This will make it possible to persist the utf8 value in caches, without having
> to decode it from the local encoding and risk case folding issues.
> 
> Stuff is renamed to more it more obvious that the type is different.
> 
> This refactoring seems to expose an existing problem in branchmap with local
> encoding being used for computing the branchmap cache.

You know that there is localstr magic here, right?

http://mercurial.selenic.com/wiki/EncodingStrategy#Round-trip_conversion

Do you have an example of an actual issue?

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list