[PATCH] test-check-commit-hg: clarify misleading "commit message rules" error

[Augie Fackler]

On Mon, Dec 22, 2014 at 03:58:23PM -0500, Augie Fackler wrote:
> On Thu, Dec 18, 2014 at 10:16:19AM -0800, Martin von Zweigbergk wrote:
> > # HG changeset patch
> > # User Martin von Zweigbergk <martinvonz at google.com>
> > # Date 1418926298 28800
> > #      Thu Dec 18 10:11:38 2014 -0800
> > # Node ID 389c3c83692ae3cbc2a1bdc5f9b5368b8db937da
> > # Parent  3f86fe9bcef0b67d1e5149e66630e46cb515ea90
> > test-check-commit-hg: clarify misleading "commit message rules" error
>
> LG, queued

Dropping mine since I lost the race with mpm.

>
> >
> > The test case doesn't only check the commit message, but also the
> > patch, which can result in confusing output like
> >
> >   +  Revision df6f06d17100 does not comply to commit message rules
> >   +  ------------------------------------------------------
> >   +  32: adds double empty line
> >   +
> >   +
> >
> > even when there are no double blank lines in the commit message. Drop
> > the "commit message" part to make it less confusing.
> >
> > diff --git a/tests/test-check-commit-hg.t b/tests/test-check-commit-hg.t
> > --- a/tests/test-check-commit-hg.t
> > +++ b/tests/test-check-commit-hg.t
> > @@ -14,7 +14,7 @@
> >    $ for node in `hg log --rev 'draft() and ::.' --template '{node|short}\n'`; do
> >    >    hg export $node | contrib/check-commit > ${TESTTMP}/check-commit.out
> >    >    if [ $? -ne 0 ]; then
> > -  >        echo "Revision $node does not comply to commit message rules"
> > +  >        echo "Revision $node does not comply to rules"
> >    >        echo '------------------------------------------------------'
> >    >        cat ${TESTTMP}/check-commit.out
> >    >        echo
> > _______________________________________________
> > Mercurial-devel mailing list
> > Mercurial-devel at selenic.com
> > http://selenic.com/mailman/listinfo/mercurial-devel
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel