[PATCH] subrepo: add full revert support for git subrepos

[Mathias De Maré]

On Sun, Dec 28, 2014 at 7:30 PM, Matt Harbison <mharbison72 at gmail.com>
wrote:

> On Sun, 28 Dec 2014 04:50:31 -0500, Mathias De Maré <
> mathias.demare at gmail.com> wrote:
>
>  # HG changeset patch
>> # User Mathias De Maré <mathias.demare at gmail.com>
>> # Date 1419759745 -3600
>> #      Son Dez 28 10:42:25 2014 +0100
>> # Node ID 092bb321b2adc00ef207ffb15fcd7446203806e9
>> # Parent  67d63ec85eb72187508692e52f14be46101707a5
>> subrepo: add full revert support for git subrepos
>>
>>
> Looks good to me, and the tests run clean with my version of git.
>
> I missed this the first time you added revert support, but you should
> probably put the @annotatesubrepoerror on this subrepo method.  (I know
> gitsubrepo.get() has it, but consider what happens now if util.rename()
> fails.)
>

Oh, good catch, thanks!. I'll send the annotation as a separate patch.

>
> --Matt
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20141228/bb816e19/attachment.html>