a question about testing hgweb (concerning spawndetached on windows)
patrick at mezard.eu
Mon Feb 3 13:45:00 CST 2014
On 03/02/14 14:09, Simon Heimberg wrote:
> Do we test "hgweb writing on output socket" (in the test suite)?
> If we do, this comment from mercurial.win32.spawndetached is not totally
> true. It works for me with python 2.6.6 on windows 7 x64, when running
> under MinGW/MSYS.
> # Not running the command in shell mode makes Python 2.6 hang when
> # writing to hgweb output socket.
> comspec = os.environ.get("COMSPEC", "cmd.exe")
> args = comspec + " /c " + arg
> copied from mercurial.win32.spawndetached,
> see http://selenic.com/repo/hg/file/a959f7167077/mercurial/win32.py#l330
> This comment originates from 2f7a38f336f4, submitted by Patrick Mezard
> <pmezard at gmail.com>.
> see http://selenic.com/repo/hg/rev/2f7a38f336f4/#l3.16
> At my windows computer, the tests with 'hg serve' run much better when not
> running with 'COMSPEC'.
The python 2.6 was 2.6.1 at best and it is likely the bug got fixed since then. If it works for you in all relevant Windows setup, just get rid of it.
More information about the Mercurial-devel