[PATCH 2 of 4] revset: changed limit revset implementation to work with lazy revsets
Lucas Moscovicz
lmoscovicz at fb.com
Tue Feb 11 12:50:51 CST 2014
# HG changeset patch
# User Lucas Moscovicz <lmoscovicz at fb.com>
# Date 1390954770 28800
# Tue Jan 28 16:19:30 2014 -0800
# Node ID 6a54b66aa4d1acaa02bb1292d4432cc37bdd6266
# Parent 44be4f156c4bc8f021bb303993d1311a0e4434c8
revset: changed limit revset implementation to work with lazy revsets
Performance benchmarking:
$ time hg log -qr "first(branch(default))"
0:9117c6561b0b
real 0m3.130s
user 0m3.025s
sys 0m0.074s
$ time ./hg log -qr "first(branch(default))"
0:9117c6561b0b
real 0m0.300s
user 0m0.198s
sys 0m0.069s
diff --git a/mercurial/revset.py b/mercurial/revset.py
--- a/mercurial/revset.py
+++ b/mercurial/revset.py
@@ -944,8 +944,17 @@
# i18n: "limit" is a keyword
raise error.ParseError(_("limit expects a number"))
ss = subset.set()
- os = getset(repo, baseset(repo), l[0])[:lim]
- return baseset([r for r in os if r in ss])
+ os = getset(repo, baseset(repo), l[0])
+ bs = baseset([])
+ it = iter(os)
+ for x in xrange(lim):
+ try:
+ y = it.next()
+ if y in ss:
+ bs.append(y)
+ except (StopIteration):
+ break
+ return bs
def last(repo, subset, x):
"""``last(set, [n])``
More information about the Mercurial-devel
mailing list