[PATCH 5 of 8] revset: added lazyset implementation to grep revset
Lucas Moscovicz
lmoscovicz at fb.com
Tue Feb 11 14:55:20 CST 2014
# HG changeset patch
# User Lucas Moscovicz <lmoscovicz at fb.com>
# Date 1391126598 28800
# Thu Jan 30 16:03:18 2014 -0800
# Node ID e83543ce7069828b0271f798b68fd682f8174c03
# Parent 336524e10809d78981001dda5465295b7d312109
revset: added lazyset implementation to grep revset
Performance benchmarking:
$ time hg log -qr "first(grep(hg))"
0:9117c6561b0b
real 0m2.214s
user 0m2.163s
sys 0m0.045s
$ time ./hg log -qr "first(grep(hg))"
0:9117c6561b0b
real 0m0.211s
user 0m0.146s
sys 0m0.035s
diff --git a/mercurial/revset.py b/mercurial/revset.py
--- a/mercurial/revset.py
+++ b/mercurial/revset.py
@@ -800,14 +800,15 @@
gr = re.compile(getstring(x, _("grep requires a string")))
except re.error, e:
raise error.ParseError(_('invalid match pattern: %s') % e)
- l = []
- for r in subset:
- c = repo[r]
+
+ def matches(x):
+ c = repo[x]
for e in c.files() + [c.user(), c.description()]:
if gr.search(e):
- l.append(r)
- break
- return baseset(l)
+ return True
+ return False
+
+ return lazyset(subset, matches)
def _matchfiles(repo, subset, x):
# _matchfiles takes a revset list of prefixed arguments:
More information about the Mercurial-devel
mailing list