[PATCH 4 of 7 (push is done; 12 more to go for pull)] push: move outgoing check logic in its own function

[Pierre-Yves David]

On 02/11/2014 01:53 PM, Olle wrote:
>
>
>
> On Tue, Feb 11, 2014 at 10:32 PM, <pierre-yves.david at ens-lyon.org
> <mailto:pierre-yves.david at ens-lyon.org>> wrote:
>
>     # HG changeset patch
>     # User Pierre-Yves David <pierre-yves.david at logilab.fr
>     <mailto:pierre-yves.david at logilab.fr>>
>     # Date 1391144481 28800
>     #      Thu Jan 30 21:01:21 2014 -0800
>     # Node ID 2890c2e587627bd14728ccaf6eacc581ee7a4fa9
>     # Parent  ee7be5db8f2443a3c97a33b3fe4276d2af7e36fd
>     push: move outgoing check logic in its own function
>
>     Now that every necessary information is held in the `pushoperation`
>     object, we
>     can extract the part responsible of aborting the push to it's own
>     function.
>
>     This changeset is mostly pure code movement. the exception is the
>     fact this
>     function a value to decide if changeset bundle should be pushed.
>
> you accidentally a word there:
>
> This changeset is mostly pure code movement. the exception is the fact this
> function returns a value to decide if changeset bundle should be pushed.

good spot. A "returns" is missing here.