[PATCH 7 of 7] run-tests: unnecessary globs also count as warnings

Simon Heimberg simohe at besonet.ch
Thu Feb 13 16:37:01 CST 2014


# HG changeset patch
# User Simon Heimberg <simohe at besonet.ch>
# Date 1392276584 -3600
#      Thu Feb 13 08:29:44 2014 +0100
# Node ID 849c295a2349281de13fe11ad26ea63a428593cd
# Parent  13e3899cf9a242d61348c23001ab0d4f2801965a
run-tests: unnecessary globs also count as warnings

When a glob is unnecessary, now there's a diff output and 'run-tests.py -i'
works for accepting the output.
On windows, some tests which have "passed" currently (with some info lines
printed) will now be reported as "warned". (I recommend to recognize "warned"
by buildbot before applying this patch.)

diff -r 13e3899cf9a2 -r 849c295a2349 tests/run-tests.py
--- a/tests/run-tests.py	Thu Feb 13 08:27:53 2014 +0100
+++ b/tests/run-tests.py	Thu Feb 13 08:29:44 2014 +0100
@@ -799,9 +799,8 @@
                     lout = el[:-1] + ' (glob)\n'
                     r = 0 # warn only
                 elif r == '-glob':
-                    log('\ninfo, unnecessary glob in %s (after line %d):'
-                        ' %s (glob)\n' % (test, pos, el[:-1]))
-                    r = True # pass on unnecessary glob
+                    lout = ''.join(el.rsplit(' (glob)', 1))
+                    r = 0 # warn only
                 else:
                     log('\ninfo, unknown linematch result: %r\n' % r)
                     r = False




More information about the Mercurial-devel mailing list