[PATCH] rebase: do not raise an UnboundLocalError when called with wrong rev (issue4106)
simohe at besonet.ch
Fri Feb 14 00:32:25 CST 2014
Am 14.02.2014 01:35, schrieb Pierre-Yves David:
> On 02/13/2014 04:22 PM, Simon Heimberg wrote:
>> Am 14.02.2014 01:16, schrieb Pierre-Yves David:
>>> On 02/13/2014 03:41 PM, Simon Heimberg wrote:
>>>> # HG changeset patch
>>>> # User Simon Heimberg <simohe at besonet.ch>
>>>> # Date 1392334460 -3600
>>>> # Node ID 0ed5bb67f3403b8e0655ee5ff2a7aeb32e307837
>>>> # Parent 0f1ef9e9e904c18f1ac96aef3a0e0d3aa5f1190c
>>>> rebase: do not raise an UnboundLocalError when called with wrong rev
>>> Is this something happening only when other extension call rebase
> So reading you description, we keep crashing. Was will be the error
> message in that case?
No, in this case it aborts telling it can not rebase a changeset on itself.
I should maybe rewrite the commit message.
> I tempted to keep crashing early, an AssertionError or
> ProgrammingError would be fine.
Maybe this would be better.
Shall I ask to unqueue? And what to choose then?
More information about the Mercurial-devel